Hi,
I am not sure if this is the right place for a patch. It improves using more than one external sdcard (or otg flash disk). In the list on home screen you can see the block id of the partition and SAF can be used to access multiple partition at once. My use case is simply to copy files from otg flash disk to sdcard or vice versa. Could you, please, implement something like this?

Thanks

Pavel

The patch is against the fdroid code for 1.56.4 version.

diff --git a/res/values-cs-rCZ/strings.xml b/res/values-cs-rCZ/strings.xml
index 69d08c0..3dbd51b 100644
--- a/res/values-cs-rCZ/strings.xml
+++ b/res/values-cs-rCZ/strings.xml
@@ -397,4 +397,5 @@ Pro vypsání namountovaných zařízení napište "mount://".<br/>
Klikněte na namountovaný záznam pro změnu práv pro zápis "rw" nebo zpět pro čtení "ro".
</p>
]]></string>
+<string name="enable_for">povolit pro</string>
</resources>
diff --git a/res/values/strings.xml b/res/values/strings.xml
index cf1a778..5308039 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -569,4 +569,5 @@ follows:
<p>This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.</p>
<p>You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/></p>
]]></string>
+<string name="enable_for">enable for</string>
</resources>
diff --git a/src/com/ghostsq/commander/adapters/HomeAdapter.java b/src/com/ghostsq/commander/adapters/HomeAdapter.java
index 78f746b..337f275 100644
--- a/src/com/ghostsq/commander/adapters/HomeAdapter.java
+++ b/src/com/ghostsq/commander/adapters/HomeAdapter.java
@@ -57,8 +57,12 @@ public class HomeAdapter extends CommanderAdapterBase {
private Item[] items = null;

private Item makeItem( int[] mode, String scheme ) {
+ return makeItem(mode, scheme, "" );
+ }
+
+ private Item makeItem( int[] mode, String scheme, String ext ) {
Item item = new Item();
- item.name = s( mode[0] );
+ item.name = s( mode[0] ) + " " + ext;
item.attr = s( mode[1] );
item.icon_id = mode[2];
item.origin = scheme;
@@ -133,7 +137,7 @@ public class HomeAdapter extends CommanderAdapterBase {
for( int i = 0; i < dirs.length; i++ ) {
if( !Utils.str( dirs[i] ) ) continue;
if( fs.equals( dirs[i] ) ) continue;
- Item item = makeItem( EXTERNAL, dirs[i] );
+ Item item = makeItem( EXTERNAL, dirs[i], dirs[i] );
ia.add( item );
}
}
@@ -144,7 +148,26 @@ public class HomeAdapter extends CommanderAdapterBase {

}
if( android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP ) {
- Item item = makeItem( SAF, SAFAdapter.ORG_SCHEME );
+ String fs = Environment.getExternalStorageDirectory().getAbsolutePath();
+ fs = Utils.mbAddSl( fs );
+ String[] dirs = ForwardCompat.getStorageDirs( ctx );
+ if( dirs != null ) {
+ for( int i = 0; i < dirs.length; i++ ) {
+ if( !Utils.str( dirs[i] ) ) continue;
+ if( fs.equals( dirs[i] ) ) continue;
+ String scheme = SAFAdapter.ORG_SCHEME + ":" + dirs[i];
+ SharedPreferences saf_sp = ctx.getSharedPreferences( SAFAdapter.ORG_SCHEME, Activity.MODE_PRIVATE );
+ String uri_s = null;
+ if( saf_sp != null ){
+ uri_s = saf_sp.getString(scheme, null);
+ }
+
+ Item item = makeItem( SAF , scheme, (uri_s == null?(s(R.string.enable_for) + " "):"") + dirs[i]);
+ item.dir = true;
+ ia.add( item );
+ }
+ }
+ Item item = makeItem( SAF , SAFAdapter.ORG_SCHEME );
item.dir = true;
ia.add( item );
}
@@ -288,10 +311,11 @@ public class HomeAdapter extends CommanderAdapterBase {
commander.dispatchCommand( R.id.exit );
return;
}
- if( "saf".equals( item.origin ) ) {
+ if(item.origin.toString().startsWith("saf")){
SharedPreferences saf_sp = ctx.getSharedPreferences( SAFAdapter.ORG_SCHEME, Activity.MODE_PRIVATE );
- if( saf_sp != null )
- uri_s = saf_sp.getString( "tree_root_uri", null );
+ if( saf_sp != null ){
+ uri_s = saf_sp.getString(item.origin.toString(), null);
+ }
if( uri_s == null ) {
commander.issue( Lollipop.getDocTreeIntent(), Commander.REQUEST_OPEN_DOCUMENT_TREE );
return;
diff --git a/src/com/ghostsq/commander/adapters/SAFAdapter.java b/src/com/ghostsq/commander/adapters/SAFAdapter.java
index e666593..f31445c 100644
--- a/src/com/ghostsq/commander/adapters/SAFAdapter.java
+++ b/src/com/ghostsq/commander/adapters/SAFAdapter.java
@@ -48,6 +48,8 @@ import android.util.SparseBooleanArray;
import android.view.ContextMenu;
import android.widget.AdapterView;

+import java.util.List;
+
@SuppressLint("NewApi")
public class SAFAdapter extends CommanderAdapterBase implements Engines.IReciever {
private final static String TAG = "SAFAdapter";
@@ -1396,7 +1398,9 @@ public class SAFAdapter extends CommanderAdapterBase implements Engines.IRecieve
public static void saveURI( Context ctx, Uri uri ) {
SharedPreferences saf_sp = ctx.getSharedPreferences( SAFAdapter.ORG_SCHEME, Activity.MODE_PRIVATE );
SharedPreferences.Editor editor = saf_sp.edit();
- editor.putString( "tree_root_uri", uri != null ? uri.toString() : null );
+ List<String> segments = uri.getPathSegments();
+ if(segments != null && segments.size() >=2 && "tree".equals(segments.get(0)))
+ editor.putString( "saf:/storage/"+segments.get(1).replace(":","/"), uri != null ? uri.toString() : null );
editor.commit();
}
}

Purpose: Easy compression and encryption from every app for sharing files with friends or storing securely in the cloud. Full compatibility with all systems due to standard 7zip format. 

Situation: I viewing e.g. a PDF in Adobe Reader or another app  

1. Click "Share". 
2. click "Secure with GC" -> in the next step, the shared file is compressed directly in a 7zip file with a user pre-defined password (normally you could use the same password for your cloud)
3. Next, another "Share" dialogue opens in which the encrypted 7zip file can be stored via GC in the cloud or be shared again with any other app like WhatsApp/eMail/GoogleDrive.

It would be awesome if GC would the be able to open the 7zip again by suggesting the mentioned pre-defined password.

With this cloud storing would easily become save while having full compatibility with many systems.

I've been hacked, and rooted, overlay installed, and being monitored. Everyone thinks I'm crazy, even you the reader.
- My wonderful hacker left me a gift. They installed Goast Commander on my phone. It doesn't have SU and they've implemented Administrative privileges to limit my attempts to get them out of my phone.
- GC having it's own set of privileges allows me to get to root / it would be extremely convenient to execute a command that list everything to a text file.
> Tree /*.* > TreeLst.txt with the obvious switches for single directory lever with all sublevels, hidden files, and or the entire structure.
- A scanning program says I've got 6500+ files. It would be nice to show people I'm not crazy.
- Currently, I have to install Keis on a laptop and copy everything over to a PC.
* This request benifets the collection of Forensic Data.

When I copy a folder with lots of files from a network share to an SD card (through SAF) Ghost Commander currently copies the files to the local storage. Only then it tries to copy the files to the SD card (I supposes that's another stupid Android limitation for our "security" and you can't copy files directly to the SD card) and complains that some of the files already exist.
That would save lots of time if the check would be performed for each file before it is actually copied.
This would greatly help in quickly synchronising folders which do not change frequently.